|
Description
|
While examining some comments about a particular message related to MODE SENSE(6)
and MODE SENSE(10) messages, I discovered that megasas has inconsistent case statement
usage:
3464 switch (pkt->pkt_cdbp[0]) {
3465 /* Mode sense */
3466 case 0x15 : /* mode select(6) */
3467 case 0x55 : /* mode select(10) */
3468 case 0x1a : /* mode sense(6) */
3469 case 0x5a : /* mode sense(10) */
3470 case 0x5e : /* ??? */
3471 case 0x4d : /* log sense */
3472 case 0x35 : /* Synchronize Cache */
3473 return_mfi_pkt(instance, cmd);
3474 *cmd_done = 1;
3475
3476 return (NULL);
3477 case SCMD_READ:
3478 case SCMD_WRITE:
3479 case SCMD_READ_G1:
3480 case SCMD_WRITE_G1:
Instead of using 0x15, 0x55... etc, the block of lines from 3466 to 3472 should use
the symbolic names used in the rest of the function, and used throughout the rest
of the kernel. We can also do without the /* which command is this? */ commentary.
|