OpenSolaris

Printable Version Enter a New Search
Bug ID 6472019
Synopsis lx_proc uses __DATE__, __TIME__
State 10-Fix Delivered (Fix available in build)
Category:Subcategory kernel:brandz
Keywords wsdiff
Responsible Engineer Russell Blaine
Reported Against
Duplicate Of
Introduced In solaris_nevada
Commit to Fix snv_50
Fixed In snv_50
Release Fixed solaris_nevada(snv_50) , solaris_10u4(s10u4_01) (Bug ID:2144876)
Related Bugs 6404876
Submit Date 18-September-2006
Last Update Date 19-January-2007
Description
kernel/fs/lx_proc and kernel/fs/amd64/lx_proc both show up in the list of changed
files that wsdiff creates for each nightly build.  And sure enough, in
lxpr_read_version(), there's a reference to __DATE__ and __TIME__, which we'd just
gone to great lengths to remove from the build.

I suppose that this is there for compatibility reasons, but the false positives are
annoying (and what are the implications for a patch, etc.).  I believe that other
implementations (Janus, maybe) cooked this value up as something static, because no
one really cares about the value, but that may not be appropriate, either.
This was raised during the code review too, and we agreed to remove it
then.  I believe it was removed from a different routine, but obviously
this instance should have been taken care of too.
Work Around
N/A
Comments
N/A