|
Description
|
Over the past week, I've noticed a few nits related to the Clearview
IPMP work that we should address:
1. The IPNDP_IPMP_HOOK_OFFSET constant is no longer needed, but still
defined. It should be removed.
2. The ipif_arp_down() function was renamed to ipif_resolver_down(),
but a few stray references to ipif_arp_down() remain. These should
be fixed.
3. In ipmp_illgrp_cast_ill(), there is logic to handle a NULL ill_grp
that is no longer possible (since we no longer clear ill_grp during
I_PUNLINK). That code should be removed.
4. A number of functions in ipmp.c use ILL_CAN_LOOKUP() and then do an
ill_refhold(). This is fine, but there's a utility function that
does both: ill_check_and_refhold(). Would be slightly simpler to
have the code use that function.
|
