|
Description
|
Peter.Memishian noticed this:
gldv3_warning() passes an uninitialized cnt variable into dladm_get_linkprop(). dladm_get_linkprop() checks that cnt is nonzero internally, so having it uninitialized will lead to unpredictable results.
It would also help to add comments around gldv3_warning explaining the purpose of this function, which was added to alert an administrator attempting to use ndd for ethernet/MII props to use dladm instead. Note that ndd is not used for any other datalink type, which makes it permissible for gldv3_warning to test for support of flowctrl (introduced by Brussels) before emitting the warning for Brussels-ized ethernet drivers only.
|
