OpenSolaris

Printable Version Enter a New Search
Bug ID 6736517
Synopsis onnv gate Comment checking script is too strict
State 10-Fix Delivered (Fix available in build)
Category:Subcategory consolidation:os-net-tools
Keywords
Responsible Engineer John Beck
Reported Against
Duplicate Of
Introduced In solaris_nevada
Commit to Fix snv_97
Fixed In snv_97
Release Fixed solaris_nevada(snv_97)
Related Bugs 6538468
Submit Date 12-August-2008
Last Update Date 28-August-2008
Description 
The current Comment checking does as part of `hg pbchk` uses this regular expression:

^(Contributed by .*|backout \d{7})

to catch miscellaneous stuff besides bug IDs and ARC cases.  This is too strict in two ways:

* "Portions contributed by ..." should be accepted
* History has shown that "backout" is often spelled "back out" and "back-out"

Since it is very simple to tweak the regular expression to support these alternate forms, we should do so.
Work Around 
N/A
Comments 
N/A