OpenSolaris

Printable Version Enter a New Search
Bug ID 6710070
Synopsis build-webrev doesn't clean up MQ gates
State 10-Fix Delivered (Fix available in build)
Category:Subcategory xvm:utility
Keywords xvm-gate
Responsible Engineer Tim Foster
Reported Against
Duplicate Of
Introduced In
Commit to Fix snv_93
Fixed In snv_93
Release Fixed solaris_nevada(snv_93)
Related Bugs
Submit Date 3-June-2008
Last Update Date 3-July-2008
Description
Doing a putback, I got:

...
pushing to /ws/xvm-gate///virtinst.hg
abort: source has mq patches applied

The problem seems to be that the gate's prechangegroup-hook
runs build-webrev. My changes had a bunch of stuff in 
xen.hg/.hg/patches, virtinst.hg/.hg/patches etc.

So what seems to have happened is that a push was made,
and that called webrev from the hook. webrev pushed all
the patches onto virtinst.hg, and then we tried to push
that. hg complained loudly and we errored out.

build-webrev needs to be more careful and clean up after
itself. Additionally, push_gate() should probably do
the pop instead of push_gates().
Work Around
N/A
Comments
N/A