OpenSolaris

Printable Version Enter a New Search
Bug ID 6683667
Synopsis fab_prep_basic_erpt() has terrible error semantics
State 10-Fix Delivered (Fix available in build)
Category:Subcategory pcie-sw:pcie
Keywords
Responsible Engineer Krishna Elango
Reported Against
Duplicate Of
Introduced In solaris_nevada
Commit to Fix snv_88
Fixed In snv_88
Release Fixed solaris_nevada(snv_88) , solaris_10u6(s10u6_02) (Bug ID:2161174)
Related Bugs 6510830
Submit Date 2-April-2008
Last Update Date 16-July-2008
Description 
In fab_prep_basic_erpt(), we nvlist_dup() new_detector, but we

a) continue to use 'new_detector' even if nvlist_dup fails
b) ignore the results of nvlist_add_*(), all of which can fail
c) nvlist_dup() 'new_detector', but never free it

All of this yields a pathologically broken function.  While the
first two are only error paths, the third one causes fmd to leak
memory over time.
Work Around 
N/A
Comments 
N/A