OpenSolaris

Printable Version Enter a New Search
Bug ID 6650337
Synopsis cleanup numeric label in macro RESV_OFFSET
State 10-Fix Delivered (Fix available in build)
Category:Subcategory kernel:vm
Keywords
Responsible Engineer James Anderson
Reported Against snv_82
Duplicate Of
Introduced In
Commit to Fix snv_82
Fixed In snv_82
Release Fixed solaris_nevada(snv_82)
Related Bugs
Submit Date 15-January-2008
Last Update Date 31-January-2008
Description 
The macro RESV_OFFSET has a hard coded numeric label which should be cleaned up.  Also the existing text label is unused.  Recommendation is to replace the numeric label with the existing text label passed into the macro.

#define RESV_OFFSET(tsbinfo, resva, tmp1, label)                        \
        /* BEGIN CSTYLED */                                             \
        lduh    [tsbinfo + TSBINFO_SZCODE], tmp1                        ;\
        brgz,pn tmp1, 9f                                                ;\
          nop                                                           ;\
        ldx     [tsbinfo + TSBINFO_VADDR], tmp1                         ;\
        .global label/**/_resv_offset                                   ;\
label/**/_resv_offset:                                                  ;\
        sllx    tmp1, (64 - MMU_PAGESHIFT4M), tmp1                      ;\
        srlx    tmp1, (64 - MMU_PAGESHIFT4M), tmp1                      ;\
        or      tmp1, resva, resva                                      ;\
9:      /* END CSTYLED */
OK I was wrong about the text label, it is used for patching the TGB reserved VAs.

This CR is only requesting changing the hard coded numeric label to a unique text label.
Work Around 
N/A
Comments 
N/A