|
Description
|
During code inspection of 6571957 (S10 backport), the inspection team identified few nits. Most of them has no impact on binary and I believe that all described nits have no impact on functionality. So this CR is only a request for code cleanup.
File nge.h:
a comment could be added here describing the role of buf_sign
File nge_main.c:
nge_m_stop(): remove invalid comment /* Try to wait all the buffer post to upper layer be released */
nge_m_start(): nge_problem(ngep, "nge_init_rings() failed,err=%x") needs an argument
nge_m_start(): function should return valid errno values as described to GLD v3
specification
File nge_rx.c:
nge_recv_recycle(): this function would benefit from a comment describing the overall behaviour of the function (and particularly the condition under which freemsg() is used to re-enter the function)
|
