OpenSolaris

Printable Version Enter a New Search
Bug ID 6636420
Synopsis ahci driver needs to better organize sentences and log driver instance information
State 10-Fix Delivered (Fix available in build)
Category:Subcategory driver:ahci
Keywords ahci | ahci-phase2 | ncq | rtiq_internal | sata
Responsible Engineer Ying Tian
Reported Against
Duplicate Of
Introduced In solaris_nevada
Commit to Fix snv_93
Fixed In snv_93
Release Fixed solaris_nevada(snv_93) , solaris_10u8(s10u8_01) (Bug ID:2169584)
Related Bugs 6511021 , 6665032
Submit Date 3-December-2007
Last Update Date 16-July-2009
Description 
'if/else' should be used to handle the following conditions since those three command types are exclusive:

...
	if (NON_NCQ_CMD_IN_PROGRESS(ahci_portp))
		finished_tags = ahci_portp->ahciport_pending_tags &
		    ~slot_status & AHCI_SLOT_MASK(ahci_ctlp);

	if (NCQ_CMD_IN_PROGRESS(ahci_portp))
		finished_tags = ahci_portp->ahciport_pending_ncq_tags &
		    ~slot_status & AHCI_NCQ_SLOT_MASK(ahci_portp);
...

Moreover, ahci_log failed to log the driver instance information.
Work Around 
N/A
Comments 
N/A