|
Description
|
During backport of 6389571 to sc31u4, reviewers agreeded to create this RFE:
" get_ipmp_groups_from_rlist returns ssm_prop_err_t type
yet we don't use them in the inline code ie : we return 0 or 1 depending
Because this is a straight backport from SC3.2, the code has been taken as is.
It was decided that a new low priority RFE would be raised to address this issues listed above."
cmd/ssm_wrapper/ssm_ipmp.c
boolean_t
local_node_has_nafo_group(void)
{
/* Get all IPMP groups */
rc = pnm_group_list(&all_nafo_groups);
if (rc != 0 || all_nafo_groups == NULL) {
=> it should be rc != SSM_PROP_ERR_NOERR
if (rc != SSM_PROP_ERR_NOERR || all_nafo_groups == NULL) {
(SSM_PROP_ERR_NOERR is currently equal to zero)
Using "magic numbers" in cmd/ssm_wrapper/ssm_ipmp.c
groupbuf[200] - could the 200 be a #define,
also the sleep (1) in get_ipmp_groups_from_rlist(
|