OpenSolaris

Printable Version Enter a New Search
Bug ID 6415507
Synopsis audit TX code review issues
State 10-Fix Delivered (Fix available in build)
Category:Subcategory audit:kernel
Keywords CC_Evaluation
Responsible Engineer Ric Aleshire
Reported Against
Duplicate Of
Introduced In solaris_nevada
Commit to Fix snv_98
Fixed In snv_98
Release Fixed solaris_nevada(snv_98)
Related Bugs 6415535 , 6449280
Submit Date 19-April-2006
Last Update Date 13-May-2009
Description
## 06/04/19 gww ##
usr/src/uts/common/c2/audit.c
303, 353 Why is this change made?  What does it have to do
with TX?  Why is this now being call called from itself?

remove the changes here that add the label token.
Add output of the label token to the AUDIT_SETSUBJ macro
in audit_kernel.h  Also probably add <sys/tsol.label.h>
there.

usr/src/uts/common/c2/audit_event.c
aus_kill 1436-1437 why isn't a label associated if pid <= 0?

usr/src/uts/common/c2/audit_kevents.h
346 Why did MAX_KEVENTS change?  Why is 580 correct?  What does
this do to the alignment of au_kcontext_t?  Perhaps 512 is also
poorly aligned.

usr/src/uts/common/c2/audit_start.c
remove the changes here see audit.c comments about AUDIT_SETSUBJ

usr/src/uts/common/c2/audit_token.c
Implement the correct form of the variable length label.
1136-1138: compute the label length from the length field
of the label.  Or precompute the length thing and then use
that if the performance suffers.

It is a label token.  (It just currently contains an SL.)
1124: Fix the comment s/sensitivity//
If this is made generic, it can contain any type of label.
Work Around
N/A
Comments
N/A