OpenSolaris

Printable Version Enter a New Search
Bug ID 6334580
Synopsis nge_gld_start function does not release mutex lock when error path
State 10-Fix Delivered (Fix available in build)
Category:Subcategory driver:nge
Keywords
Responsible Engineer Jason Jiang
Reported Against
Duplicate Of
Introduced In solaris_nevada
Commit to Fix snv_32
Fixed In snv_32
Release Fixed solaris_nevada(snv_32) , solaris_10u2(s10u2_05) (Bug ID:2133033)
Related Bugs 6339474 , 6342238 , 6353971 , 2133034
Submit Date 9-October-2005
Last Update Date 16-March-2007
Description 
In src/uts/common/io/nge/nge_main.c, "ngep->genlock" should be released before return in line 930-931. 

   916  static int
   917  nge_gld_start(gld_mac_info_t *macinfo)
   918  {
   919          int err;
   920          nge_t *ngep;
   921
   922          ngep = NGE_STATE(macinfo);
   923
   924          /*
   925           * Start processing and record new GLD state
   926           */
   927          mutex_enter(ngep->genlock);
   928          ngep->link_up_msg = ngep->link_down_msg = " (initialised)";
   929          err = nge_chip_start(ngep);
   930          if (err == DDI_FAILURE)
   931                  return (err);
   932          ngep->nge_gld_state = NGE_GLD_STARTED;
   933          mutex_exit(ngep->genlock);
Work Around 
N/A
Comments 
N/A