|
Description
|
When building ON with gcc (on x86) there are warnings in snoop.
1. an actual bug - gcc is upset about this call in snoop_dhcp.c:
display_ip((*start++ / 4), "%s at = %s",
option_types[save], &start);
it complains about the order of evaluation being undefined. The C Standard
appears to confirm this in 6.5.2.2:
The order of evaluation of the function designator, the actual arguments, and
subexpressions within the actual arguments is unspecified, but there is a
sequence point before the actually call.
This may happen to work with cc but we may just be lucky.
2. gcc doesn't like pointer<->int conversion where the sizes differ - uintptr_t to
the rescue.
2. other minor cleanup for gcc. things like 'static' on struct declarations,
places we should return a value and don't, implicit ints and the like. In fact
there seems to be a few functions that return something useful on success but
forget to return anything on failure, which should probably be looked at.
xxxxx@xxxxx.com 2005-05-10 21:58:55 GMT
|