OpenSolaris

Printable Version Enter a New Search
Bug ID 5089054
Synopsis iprbprobe() validates ILINE, which it has no business doing
State 10-Fix Delivered (Fix available in build)
Category:Subcategory driver:iprb
Keywords rtiq_reviewed
Responsible Engineer Milan Jurik
Reported Against s10_52 , s10_64
Duplicate Of
Introduced In solaris_2.6
Commit to Fix snv_70
Fixed In snv_70
Release Fixed solaris_nevada(snv_70)
Related Bugs 5026406 , 5040911
Submit Date 19-August-2004
Last Update Date 8-August-2007
Description
iprbprobe() contains the following snippet:

 #if defined(i86pc)
        if ((iline == 0) || (iline > 15)) {
                cmn_err(CE_WARN, "iprb: iline value out of range: %d", iline);
                pci_config_teardown(&handle);
                return (DDI_PROBE_FAILURE);
        }
 #endif

Drivers have no business validating ILINE; that's for the framework
to do.  In this case, a Toshiba A1 laptop is failing to set ILINE, and
(presumably) has the appropriate info in ACPI.  

Probably the entire iprbprobe() should be removed, as probe() is now
deprecated; but certainly that section of probe() is misguided at best.
Work Around
N/A
Comments
N/A